Move libc termios bindings from POSIX to Linux#3251
Closed
hovsater wants to merge 4 commits into
Closed
Conversation
hovsater
changed the title
Contributor
Author
|
I'll rebase this branch on |
c_cc is not an array of Cc members. The Cc enum are the index positions. The value at a given index position is an arbitrary byte value.
Contributor
Author
|
@ManuLinares and I decided that we'll merge all work into a single PR. See #3254 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Based on #3248. Merge that one first.
This moves the current
termiosimplementation out oflib/std/libc/os/posix.c3and intolib/std/libc/os/linux.c3. The definitions were not generic POSIX definitions. They match Linux/glibc specifictermiosconstants, control-character indexes, andstruct termioslayout.lib/std/libc/termios.c3is also narrowed from POSIX to Linux so the API is only exposed for the platform it currently matches.