Changed Rect edge inclusivity behavior#3253
Open
cmann1 wants to merge 7 commits into
Open
Conversation
`contains_point` is now exclusive on the maximum edge
Collaborator
|
If so, then we don't really need the fix when adding points, right? |
Contributor
Author
|
You mean the changes to Since the added point could become the new maximum edge, and |
lerno
reviewed
May 24, 2026
| @return "The resulting rectangle" | ||
|
|
||
| @ensure return.contains_point(point) | ||
| @ensure return.contains_point_inclusive(point) |
Collaborator
There was a problem hiding this comment.
So maybe we could make this not even a requirement and also drop the "nexhigher" part. Then have min/max with Box which is inclusive?
Contributor
Author
There was a problem hiding this comment.
Yeah I think that makes sense
Contributor
Author
|
Hopefully all of that in one PR is ok. If you do want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains_pointis now exclusive on the maximum edge