Integration test/facilities - #63
Open
jobin2005 wants to merge 16 commits into
Open
Conversation
… natively in facilities test suite
…ose optional chaining TS deviations
…ed via Typescript narrowing
for facility tests
Swassyman
requested changes
Aug 5, 2026
| maxCapacity: 100, | ||
| }) | ||
| .returning(); | ||
| assert(venue); |
Member
There was a problem hiding this comment.
always check
assert( something != null)fix this same mistake everywhere else
| }); | ||
|
|
||
| // Confirms the repository lacks transaction serializability or unique constraints, permitting duplicates | ||
| expect(allAssignments.length).toBeGreaterThan(1); |
Member
There was a problem hiding this comment.
shouldn't this be equal to 1? or am i missing something?
Collaborator
Author
There was a problem hiding this comment.
It is actually to check if the race condition is correctly handled.(Multiple people assigning a facility at the same time)
| ); | ||
| }); | ||
|
|
||
| test("Unassignment strictly enforces ownership permissions and valid ID bindings", async () => { |
Member
There was a problem hiding this comment.
i feel like a better name could be used here
| workflowParticipationPolicy: "include", | ||
| overlapPolicy: "shared", | ||
| }); | ||
| await changeAvailabilityDb(facility.id, { availability: true }); |
Member
There was a problem hiding this comment.
use service functions for changing availabiliity, here the bug should fix that
merge latest commit
jobin2005
force-pushed
the
integration-test/facilities
branch
from
August 6, 2026 05:34
0411333 to
2c22d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration tests for facilities