FEATURE: [xalign] add interactive order minimum amount #2382
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboyliao
force-pushed
the
dboy/xalign/interactive-min-amount
branch
2 times, most recently
from
f35b76e to
f84fd61
Compare
c9s
approved these changes
Jan 9, 2026
dboyliao
force-pushed
the
dboy/xalign/interactive-min-amount
branch
from
dcd341e to
9fee507
Compare
kbearXD
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about to let
xalignhandle order submission in three different modes:amount <= InstantAlignAmount: submit aligning order immediatelyInstantAlignAmount < amount < InteractiveOrderMinAmount: submit aligning order with a tolerance to the deviation of expected balances (the old behavior).amount >= InteractiveOrderMinAmount: submit aligning order with interactive order via slack, supporting manual confirmation.