Skip to content

Conversation

@anywhy
Copy link
Contributor

@anywhy anywhy commented Jan 19, 2026

No description provided.

@anywhy anywhy requested a review from c9s as a code owner January 19, 2026 12:28
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.63%. Comparing base (5b0275f) to head (95ce198).
⚠️ Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
pkg/exchange/binance/stream.go 11.11% 8 Missing ⚠️
pkg/exchange/binance/parse.go 84.61% 4 Missing ⚠️
pkg/bbgo/activeorderbook.go 25.00% 3 Missing ⚠️
pkg/exchange/binance/stream_callbacks.go 40.00% 3 Missing ⚠️
pkg/types/order.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   19.25%   19.63%   +0.37%     
==========================================
  Files        1070     1077       +7     
  Lines       71451    72597    +1146     
==========================================
+ Hits        13759    14254     +495     
- Misses      56415    57035     +620     
- Partials     1277     1308      +31     
Files with missing lines Coverage Δ
pkg/types/order.go 1.02% <0.00%> (-0.05%) ⬇️
pkg/bbgo/activeorderbook.go 23.98% <25.00%> (-0.21%) ⬇️
pkg/exchange/binance/stream_callbacks.go 24.76% <40.00%> (+24.76%) ⬆️
pkg/exchange/binance/parse.go 24.68% <84.61%> (+4.19%) ⬆️
pkg/exchange/binance/stream.go 6.29% <11.11%> (+6.29%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd452b...95ce198. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anywhy anywhy force-pushed the binance-algo-order-ws branch 2 times, most recently from 95ce198 to 6b204bb Compare January 20, 2026 01:33
@c9s c9s merged commit 0beccc0 into c9s:main Jan 20, 2026
7 checks passed
@anywhy anywhy deleted the binance-algo-order-ws branch January 20, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants