(Demo) Patient view resource table mockup#5595
Draft
dippindots wants to merge 3 commits into
Draft
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add patient resource table with tabbed layout - Refine resource table pagination and UI - Polish resource column picker and metadata columns - Add resource filter builder with checkbox support - Reuse LazyMobXTable for resources - Promote resource tabs in study view - Allow study resource table routes - Trim unused resource table helpers and demo data Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dippindots
force-pushed
the
copilot/refine-pagination-ui
branch
from
039518c to
a444268
Compare
Sets up Storybook (webpack5 + SWC) with a LoadingIndicator story as the first example, and wires Playwright screenshot tests against the static Storybook build for reliable component-level visual regression testing. ## What's included ### Storybook - .storybook/main.ts — webpack5 builder, SWC transpiler configured for MobX legacy decorators (legacyDecorator + React 16 classic JSX runtime), SCSS module chain with sass-resources-loader mirroring rspack.config.js - .storybook/preview.ts — viewport defaults + React 16 useInsertionEffect stub - src/shared/components/loadingIndicator/LoadingIndicator.stories.tsx — 4 stories: Small, Big, WithMessage, NotLoading (renders nothing) ### Visual regression tests - storybook-visual-tests/playwright.config.ts — points at localhost:6006, PW_DOCKER flag for Docker-vs-host snapshot separation, PW_UPDATE_SNAPSHOTS support matching the existing E2E playwright config pattern - storybook-visual-tests/tests/LoadingIndicator.visual.spec.ts — screenshot tests for all 4 stories using iframe.html isolation (no backend needed) - storybook-visual-tests/tests/__snapshots__/ — committed baseline PNGs - scripts/serve-and-test-storybook.js — serves storybook-static/ and runs playwright in the same process, cleans up on exit ### GitHub Actions CI - .github/workflows/storybook-visual-tests.yml — runs on every PR and push to master/rc; installs deps, builds Storybook, runs visual diffs, uploads diff artifacts on failure; workflow_dispatch supports update_snapshots input ### Package.json scripts - pnpm storybook — dev server on :6006 - pnpm build-storybook — static build - pnpm test:storybook — run visual tests (storybook-static must exist) - pnpm test:storybook:ci — build + test in one command - pnpm test:storybook:update — regenerate all baselines Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test:
localStorage.netlify = "deploy-preview-5595--cbioportalfrontend"in the browser console first and refresh the page