Skip to content

Conversation

Akshita-Goel
Copy link

@Akshita-Goel Akshita-Goel commented Apr 3, 2025

Fix #11480

Describe changes proposed in this pull request:

  • Created an abstract base class: Implemented a common parent class that both Redis and Ehcache configurations can extend.
  • Template method pattern: Added a reusable createCacheResolver() method to standardize cache resolver creation.
  • Simplified cache creation: Made adding new caches as simple as defining a new method using the template.
  • Consistent naming convention: Centralized the application name prefix logic for cache names.
  • Better documentation: Added Javadoc explaining the purpose of each method.

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@inodb inodb requested a review from Copilot April 4, 2025 01:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

docs/deployment/customization/Caching.md:35

  • [nitpick] Consider adding a delimiter between appName and cacheName to improve readability and avoid potential naming collisions.
return new NamedCacheResolver(cacheManager(), appName + cacheName);

Copy link

sonarqubecloud bot commented Apr 4, 2025

Copy link

stale bot commented Jul 19, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Caching.md to remove similar code

1 participant