chore: switch pytest to importlib import mode for monorepo#50
Merged
Conversation
- Add --import-mode=importlib to root pytest config - Move cell2zarr test helpers from conftest.py to src/cell2zarr/_testing.py - Remove tests/__init__.py files (not needed with importlib mode) This allows uv run pytest (and pytest-watcher) to work from the monorepo root without test module name collisions across packages. pytest recommends importlib mode for new projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch pytest to
--import-mode=importlibsouv run pytest(andptw) work from the monorepo root without test module name collisions.pyproject.tomlconftest.pytosrc/cell2zarr/_testing.py(conftest should only contain fixtures, not importable helpers)tests/__init__.pyfiles (importlib mode doesn't need them)pytest officially recommends importlib mode for new/modern projects — see https://docs.pytest.org/en/stable/explanation/pythonpath.html#which-import-mode
Test plan
uv run pytestfrom root → 181 tests passmake test→ 84 tests pass (api)make test-cell2zarr→ 69 tests pass