Skip to content

feat(api): add GET /admin/datasets to list all datasets#55

Merged
hweej merged 1 commit intomainfrom
feature/admin-list-datasets
Apr 24, 2026
Merged

feat(api): add GET /admin/datasets to list all datasets#55
hweej merged 1 commit intomainfrom
feature/admin-list-datasets

Conversation

@hweej
Copy link
Copy Markdown
Contributor

@hweej hweej commented Apr 24, 2026

Summary

  • Admin had no way to discover private dataset slugs — `/datasets` filters by caller's roles
  • Adds `GET /admin/datasets` returning every dataset with full `DatasetAdminResponse` (includes `is_public`, `required_roles`, `datasource_id`)

Test plan

  • `test_list_datasets_includes_private`: private dataset shows up with its required_roles
  • Existing admin tests still pass (9/9)

Mirrors list_datasources. Returns the full DatasetAdminResponse for
every dataset regardless of visibility — the public /datasets endpoint
filters by the caller's roles, which makes it impossible for an admin
to discover private datasets by slug.
@hweej hweej merged commit df9dd79 into main Apr 24, 2026
3 checks passed
@hweej hweej deleted the feature/admin-list-datasets branch April 24, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant