fix: use Key instead of OwnKey in rawEnvVars to properly reference existing defaults in complex structs#412
Open
AndrewChubatiuk wants to merge 1 commit intocaarlos0:mainfrom
Open
Conversation
…isting defaults in complex structs
AndrewChubatiuk
added a commit
to endesapt/operator
that referenced
this pull request
Mar 2, 2026
- temporary replaced caarlos0/env with fork till caarlos0/env#412 is merged - consolidate all functions for cluster defaults population - merged CommonDefaultableParams and CommonApplicationDeploymentParams into CommonAppsParams - moved setting terminationGracePeriodSeconds to defaults management
AndrewChubatiuk
added a commit
to endesapt/operator
that referenced
this pull request
Mar 2, 2026
- temporary replaced caarlos0/env with fork till caarlos0/env#412 is merged - consolidate all functions for cluster defaults population - merged CommonDefaultableParams and CommonApplicationDeploymentParams into CommonAppsParams - moved setting terminationGracePeriodSeconds to defaults management
AndrewChubatiuk
added a commit
to endesapt/operator
that referenced
this pull request
Mar 2, 2026
- temporary replaced caarlos0/env with fork till caarlos0/env#412 is merged - consolidate all functions for cluster defaults population - merged CommonDefaultableParams and CommonApplicationDeploymentParams into CommonAppsParams - moved setting terminationGracePeriodSeconds to defaults management
AndrewChubatiuk
added a commit
to endesapt/operator
that referenced
this pull request
Mar 2, 2026
- temporary replaced caarlos0/env with fork till caarlos0/env#412 is merged - consolidate all functions for cluster defaults population - merged CommonDefaultableParams and CommonApplicationDeploymentParams into CommonAppsParams - moved setting terminationGracePeriodSeconds to defaults management
AndrewChubatiuk
added a commit
to endesapt/operator
that referenced
this pull request
Mar 2, 2026
- temporary replaced caarlos0/env with fork till caarlos0/env#412 is merged - consolidate all functions for cluster defaults population - merged CommonDefaultableParams and CommonApplicationDeploymentParams into CommonAppsParams - moved setting terminationGracePeriodSeconds to defaults management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently it's impossible to expand variable from other struct field, if configuration struct is not plain
in a given below example Config.Component.Endpoint.Value can be only obtained from env variable, but not from default value of Config.Component.Host