-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add custom block place limit. #4746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.19.4
Are you sure you want to change the base?
Conversation
@@ -167,6 +169,9 @@ public double costOfPlacingAt(int x, int y, int z, BlockState current) { | |||
if (!Baritone.settings().allowPlaceInFluidsFlow.value && !current.getFluidState().isEmpty() && !current.getFluidState().isSource()) { | |||
return COST_INF; | |||
} | |||
if (y > Baritone.settings().blockPlaceHeightLimit.value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (y > blockPlaceHeightLimit) {
What server imposes a custom height limit ? |
Any server running data packs such as Sky High which increases the default limit past the 320 limit. |
This PR only decreases the limit, it can't increase it |
Fair I was just assuming as to why people would want a custom height limit, I’m not personally sure what servers are imposing a limit on build height. |
A local SMP server I play on has a custom height limit. If you have any idea on how to make this increase and decrease the height limit, I would really want to hear it though since I couldn't come up with anything. I don't know if I'm supposed to get the instance of the Minecraft world from the settings page but I'm assuming that I'm not. |
Can you clarify if this SMP server has a height limit that is lower or greater than vanilla? |
Lower. |
any data pack raising/lowering the height limit should sync it to the client as world.dimension.height() or whatever as part of the dimension data, so this should only be necessary if some plugin is "artificially" lowering it or otherwise preventing block places above a y value |
The server doesn't use any data packs so I guess it won't sync. I'm thinking that it's done using command blocks. |
A very small PR. Closes #4743