run cabin fmt on project #1168
run cabin fmt on project #1168
Conversation
WalkthroughThe pull request updates the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Formatting results vary between versions of clang-format. Cabin now uses clang-format version 20, so please check your environment. |
To avoid stupid situations during future contributement (:
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CONTRIBUTING.md (1)
69-69: Fix punctuation and hyphenation in the clang-format note.The note currently misses a comma after “awkwardly enough” and uses “double check” instead of the hyphenated “double-check.” Correcting these will improve clarity and consistency.
Apply the following diff:
-Note that different versions of clang-format may produce different output. And awkwardly enough there is no clang-format option to pin to a specific version. Cabin is currently using version 20.1.1. Stick to it and double check your environment before trying to commit. +Note that different versions of clang-format may produce different output. And awkwardly enough, there is no clang-format option to pin to a specific version. Cabin is currently using version 20.1.1. Stick to it and double-check your environment before trying to commit.🧰 Tools
🪛 LanguageTool
[uncategorized] ~69-~69: Possible missing comma found.
Context: ...produce different output. And awkwardly enough there is no clang-format option to pin ...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~69-~69: The verb “double-check” is spelled with a hyphen.
Context: ...y using version 20.1.1. Stick to it and double check your environment before trying to commi...(DOUBLE_HYPHEN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CONTRIBUTING.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md
[uncategorized] ~69-~69: Possible missing comma found.
Context: ...produce different output. And awkwardly enough there is no clang-format option to pin ...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~69-~69: The verb “double-check” is spelled with a hyphen.
Context: ...y using version 20.1.1. Stick to it and double check your environment before trying to commi...
(DOUBLE_HYPHEN)
Thank you for your feedback. I have changed my version and now everything is fine. However, I believe that this fact is better to be mentioned in contributing guidelines. This is why I have to suggest another change |
I have noticed that there are too much of a diff on my another PR after running cabin fmt on project - so i have decided to do this separately
Summary by CodeRabbit