Pipeline dashboard by JacobCoffee · Pull Request #249 · cabotage/cabotage-app

JacobCoffee · 2026-03-14T21:27:54Z

Description

Enables the Pipeline tab

adds prometheus exporter to celeyr
adds some db columns to track other data

Closes #247

ewdurbin · 2026-03-15T00:28:53Z

Hmmmmm, most of these stats should be accessible via querying the database via .created, .updated, and .built/.error for images and .complete/.error without any additional telemetry.

Can we start there, then consider telemetry later?

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Run black formatter on deploy.py, views.py, migration - Add nosec B608 to f-string SQL with hardcoded table names - Fix migration chain: down_revision -> e5f9a2c7d834 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Narrow _REGISTRY type with an early return guard instead of assert (which bandit flags as B101). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

JacobCoffee · 2026-03-28T17:25:08Z

splitting push gateway and metrics stuff

The pipeline dashboard derives all stats from existing DB columns (created, updated, built, error, complete). The prometheus_client pushgateway integration can be added later when needed. Removes: cabotage/celery/metrics.py, all record_*_metrics() calls, PUSHGATEWAY_URL config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

JacobCoffee · 2026-03-28T17:33:10Z

Pushgateway telemetry split out to #319 for later pickup.

JacobCoffee · 2026-03-28T18:13:45Z

mucho better

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Spreads images/releases/deployments across 72h with varied build durations so the pipeline dashboard shows meaningful charts and stats. Also fixes seed login message (port 8000, correct credentials). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

SQLAlchemy's Timestamp mixin overwrites `updated` on commit. Defer timestamp assignments to raw UPDATE statements after the final commit so pipeline dashboard shows realistic durations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Spreads deploys across 90 days so 7d/30d/90d range filters show different data. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Reverts TESTING guards in render_process_container and render_podspec, and removes REGISTRY_PULL_K8S/TESTING config that were local dev workarounds, not pipeline features. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

JacobCoffee · 2026-03-28T18:30:53Z

@ewdurbin i think this is a lil bit smaller and nicer now, only using the db stuff we have. doing a final passthrough check on the py code but could use your review for a merge

The deferred _timestamp_fixups machinery was unnecessary — SQLAlchemy's `default=` only fires when no value is provided, so setting created/updated directly after flush() works fine. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

JacobCoffee · 2026-03-28T18:38:56Z

Code Review — Pipeline Dashboard

Cross-check review via Codex (gpt-5.4, xhigh effort).

Must Fix

#	Severity	File	Issue
1	High	`views.py:6989`	"Total" runtime computes `deployment.updated - image.created` which includes idle gaps between stages. Should sum `image.duration + release.duration + deploy.duration` instead.
2	High	`build.py:1660`	`image.completed_at = datetime.datetime.utcnow()` is a no-op — no mapped `completed_at` column exists on the Image model. This is a transient Python attribute that gets discarded. Remove it.
3	High	`pipeline.html:510`, `views.py:6950`	Range selector (7d/30d/90d) does not filter "Recent Runs". `loadRuns()` never sends `range` param, and the backend endpoint has no range filter.
4	Medium	`pipeline.html:483`, `views.py:6809`	Stage-average badges are mathematically wrong — averaging per-day averages gives a one-run day the same weight as a hundred-run day. Compute overall averages server-side.
5	Medium	`views.py:6956-6957`	`offset`/`limit` query params will 500 on non-integer input. Use `request.args.get("offset", 0, type=int)`.

Should Fix

#	Severity	File	Issue
6	Low	`pipeline.html:444-447`	Throughput bars (Success/Failure) overlap on days with both — same bar path/alignment, no stacking. One series hides the other.
7	Low	`pyproject.toml:82`	Bandit exclusion of entire `cabotage/scripts` dir is too broad. Use inline `# nosec B608` on the specific line instead.
8	Low	`pipeline.html:36, 135`	Dead CSS: `.pipe-kpi-sub` is unused, `.u-legend` override is redundant since `legend.show = false` is already set.
9	Low	`projects.py:879, 1492`	`trigger_type` on Release and Image models is dead code — only `Deployment.trigger_type` is consumed by the UI.

Confirmed OK

SQL queries are injection-safe: user-controlled values are bound params, interpolated identifiers come from hardcoded choices only.
No TESTING guards or mimir/loki-conf workarounds remain in the pipeline code.
duration_seconds properties are a reasonable approach given the "use existing DB columns" decision, with the caveat that updated is mutable (noted above).

JacobCoffee · 2026-03-28T18:41:02Z

7 Low pyproject.toml:82 Bandit exclusion of entire cabotage/scripts dir is too broad. Use inline # nosec B608 on the specific line instead.

i think itd be better to move scripts up a level outside of the real cabotage module code in another PR

Removes the broken defer/fixup mechanism. Instead, backdates all pipeline timestamps via raw SQL after the final ORM commit, bypassing SQLAlchemy's onupdate handlers. 15 runs across 90 days. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

JacobCoffee mentioned this pull request Mar 14, 2026

Mimir loki conf #225

Draft

JacobCoffee force-pushed the pipeline-dashboard branch from dda02e0 to 78e81e5 Compare March 14, 2026 21:31

JacobCoffee requested a review from ewdurbin March 14, 2026 22:01

JacobCoffee commented Mar 14, 2026

View reviewed changes

Comment thread cabotage/celery/tasks/build.py Outdated

JacobCoffee commented Mar 14, 2026

View reviewed changes

Comment thread cabotage/celery/metrics.py Outdated

ewdurbin force-pushed the main branch from 4530b5a to f5d264c Compare March 27, 2026 14:15

JacobCoffee and others added 10 commits March 28, 2026 12:10

pipeline dashboardin

909caf5

fix: handle empty chart state in pipeline dashboard

b5dd133

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

make the dashboard more useful

a33eb06

paginate long things

1ed7ab1

fix the compact headerr mode for pipeline tab

8f5769e

fmt

5eff4ec

fix the bandit fails

f4d7776

fix: pass CI lint and security checks

b20fc6e

- Run black formatter on deploy.py, views.py, migration - Add nosec B608 to f-string SQL with hardcoded table names - Fix migration chain: down_revision -> e5f9a2c7d834 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: resolve mypy type error in metrics push_to_gateway call

091476b

Narrow _REGISTRY type with an early return guard instead of assert (which bandit flags as B101). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

use what we have!

699879e

JacobCoffee force-pushed the pipeline-dashboard branch from e85d8dd to 699879e Compare March 28, 2026 17:18

JacobCoffee and others added 2 commits March 28, 2026 12:25

Merge branch 'main' into pipeline-dashboard

2ee8cbc

JacobCoffee commented Mar 28, 2026

View reviewed changes

Comment thread cabotage/server/models/projects.py

JacobCoffee and others added 6 commits March 28, 2026 13:18

Enable Pipeline link in Observe dropdown

1168c93

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

add some spacin

c94fc41

Right-align sha and date columns in slowest table

b2c8281

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix numnbers clipping

76105ed

JacobCoffee and others added 2 commits March 28, 2026 13:18

Seed 15 pipeline runs over 90 days with 2 failures

d461e33

Spreads deploys across 90 days so 7d/30d/90d range filters show different data. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Fix CI: exclude scripts from bandit, fix black formatting

a9f6d8f

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

JacobCoffee force-pushed the pipeline-dashboard branch from c795fe6 to a9f6d8f Compare March 28, 2026 18:21

JacobCoffee commented Mar 28, 2026

View reviewed changes

Comment thread cabotage/celery/tasks/deploy.py Outdated

JacobCoffee commented Mar 28, 2026

View reviewed changes

Comment thread cabotage/celery/tasks/deploy.py Outdated

JacobCoffee commented Mar 28, 2026

View reviewed changes

Comment thread pyproject.toml

JacobCoffee and others added 2 commits March 28, 2026 13:27

fmt

ff7aab6

JacobCoffee requested review from ewdurbin and removed request for ewdurbin March 28, 2026 18:30

JacobCoffee and others added 2 commits March 28, 2026 13:34

fixup lints

8ff0ba1

JacobCoffee and others added 3 commits March 28, 2026 13:44

Remove dead CSS (.pipe-kpi-sub, .u-legend override)

429ac15

Remove unused trigger_type from Image and Release models

1aecfdd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pipeline dashboard#249

Pipeline dashboard#249
JacobCoffee wants to merge 27 commits into
cabotage:mainfrom
JacobCoffee:pipeline-dashboard

JacobCoffee commented Mar 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ewdurbin commented Mar 15, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026 •

edited

Loading

Uh oh!

JacobCoffee commented Mar 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

JacobCoffee commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Uh oh!

ewdurbin commented Mar 15, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JacobCoffee commented Mar 28, 2026

Uh oh!

JacobCoffee commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review — Pipeline Dashboard

Must Fix

Should Fix

Confirmed OK

Uh oh!

JacobCoffee commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JacobCoffee commented Mar 14, 2026 •

edited

Loading

JacobCoffee commented Mar 28, 2026 •

edited

Loading

JacobCoffee commented Mar 28, 2026 •

edited

Loading