Raise categorized exceptions from API#38
Merged
Merged
Conversation
This is a start; not all common error cases are necessarily covered. Also omit traceback from CLI on known error. (Assisted by Claude Code; any errors are mine.)
Try best to cover all cases where a non-bug exception can be raised. (Assisted by Claude Code; any errors are mine.)
The distinction is not always possible (if concurrent fetch fails, we don't know which), and not very useful to the calling code. Keep it simple at least for now. (Assisted by Claude Code; any errors are mine.)
marktsuchida
force-pushed
the
api-exceptions
branch
from
15d8594 to
122028c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we just let whatever exception that gets raised propagate out of our API.
Introduce a categorized exception hierarchy and wrap errors so that the caller can distinguish between kinds of error (incorrect input vs no such JDK vs download/install failure).
Unanticipated exceptions (i.e., bugs) will leak out, as with any Python code, of course.
Change the CLI to omit the stack trace and just print the error message when a known error happens. Also introduce specific exit codes for the error categories.