Configure trusted proxies - #428
Merged
Merged
Conversation
jbrooksuk
marked this pull request as ready for review
August 11, 2026 18:56
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17cd20b399
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jbrooksuk
force-pushed
the
codex/fix-trusted-proxies
branch
from
August 13, 2026 08:29
01a87d6 to
39a9f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CACHET_TRUSTED_PROXIES*so forwarded HTTPS schemes are trusted correctlyRoot cause
The Cachet application converted
*to['*'], which Laravel treats as a literal IP instead of its all-proxies wildcard. That caused Livewire to generate HTTP update URLs behind TLS-terminating proxies.Validation
vendor/bin/pest tests/Feature/TrustedProxiesTest.phpvendor/bin/pint --testThe full Core suite was also attempted, but the environment's 128 MB PHP memory limit exhausted in unrelated tests.