-
Notifications
You must be signed in to change notification settings - Fork 377
cli: init with template #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cli: init with template #1721
Conversation
Thanks for this! I tested this PR using: devenv init --template github:LorenzBischof/devenv-issue-1718 And it worked as expected. |
If this feature is being considered, we should probably also merge the I also thought about maybe forcing a template prefix? We could default to We could also think about adding a |
@LorenzBischof, this is fine as it is. I don't particularly like coupling ourselves to the flake API, but this feels like a useful feature for some and we can re-implement the behaviuor separately if needed down the line. Could you please rebase this on main for the builds to pass and I'll merge it. |
4763b70
to
1faf95c
Compare
a4b318f
to
d904754
Compare
I don't think we should be using flakes for templates, we should add |
@domenkozar Could you give me a quick heads up if the following approach sounds reasonable?
This would reuse all the code from Flake templates, but would allow a future refactor if required. It also allows us to validate templates and fail if something is wrong or there are no devenv templates available. |
We're currently hacking on #1548 at https://oceansprint.org, I think we need that in order to be able to parse flakeref uris and then we can support templates directly from devenv. It's going to take a while to get this in, but I really don't want to encourage to write flake files for templates and then using devenv. |
d2da73a
to
45a9059
Compare
45a9059
to
6fd1dc4
Compare
The templates can now be specified in the Since I have no idea how far along the Snix implementation is, I do not know if it makes sense to continue. Would you consider merging this before the rewrite? |
6fd1dc4
to
6eaa325
Compare
Closes #1718