context: Rename func to AppIfConfigured#5397
Merged
francislavoie merged 2 commits intomasterfrom Feb 27, 2023
Merged
Conversation
mholt
approved these changes
Feb 27, 2023
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Great; yeah, I can 99% guarantee that nobody else is using this function.
Great. I'm in that 1%. 🤣 Or perhaps I'm not using it correctly, if you guys are really so sure about nobody would be using it... |
Member
|
Ah, sorry. Since we don't have telemetry all we can do is assume based on community interactions. Hopefully an easy change at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4893
I highly doubt anyone but ourselves used this API, so it should be safe to do this even though it's an exported function.