fix: fix index validation for PUT requests#6824
Merged
mholt merged 1 commit intocaddyserver:masterfrom Feb 4, 2025
Merged
Conversation
|
|
mholt
reviewed
Feb 3, 2025
Member
There was a problem hiding this comment.
Thanks. Did you double-check that the PUT logic below is still correct if idx == len(arr)?
case http.MethodPut:
// avoid creation of new slice and a second copy (see
// https://github.com/golang/go/wiki/SliceTricks#insert)
arr = append(arr, nil)
copy(arr[idx+1:], arr[idx:])
arr[idx] = val
v[part] = arr
Contributor
Author
|
Yes, the PUT logic works correctly when idx == len(arr). It behaves as expected by appending the new element at the end of the array. |
Contributor
Author
|
Hi, the code is all good—every test is passing except this one CI run. It hit a network issue where the self-hosted runner couldn't reach GitHub’s endpoints during the artifact upload. |
Member
|
Yeah, we have some known flaky tests. Thanks! |
mholt
approved these changes
Feb 4, 2025
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issues #6822