reverseproxy: Fix partial response not flushed to clients#7849
Open
WeidiDeng wants to merge 3 commits into
Open
reverseproxy: Fix partial response not flushed to clients#7849WeidiDeng wants to merge 3 commits into
WeidiDeng wants to merge 3 commits into
Conversation
mohammed90
reviewed
Jun 30, 2026
Comment on lines
+957
to
+974
| { | ||
| endpoint: "/partial", | ||
| status: 500, | ||
| bodyType: 1, | ||
| body: "partial", | ||
| }, | ||
| { | ||
| endpoint: "/full", | ||
| status: 500, | ||
| bodyType: 2, | ||
| body: strings.Repeat("full", 125), | ||
| }, | ||
| { | ||
| endpoint: "/empty", | ||
| status: 502, | ||
| bodyType: 2, | ||
| body: "", | ||
| }, |
Member
There was a problem hiding this comment.
Am I reading this correct, partial data is sent to client albeit with code 500? Also, how come empty response gets 502 while partial content gets 500? Is this stdlib doing it?
Member
Author
There was a problem hiding this comment.
500 is the status from the backend, caddy is just forwarding the response as is unless configured otherwise.
502 is the response by default if backend doesn't reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7845 .
Assistance Disclosure
No AI is used.