caddyconfig: Register nested named-route invokes transitively#7898
Open
SillyZir wants to merge 1 commit into
Open
caddyconfig: Register nested named-route invokes transitively#7898SillyZir wants to merge 1 commit into
SillyZir wants to merge 1 commit into
Conversation
SillyZir
marked this pull request as ready for review
July 21, 2026 02:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6435.
Record which named routes each named route invokes during extraction and transitively attach those routes (with cycle protection) when populating a server's named_routes, so nested invoke targets are no longer dropped.
Previously,
invoke fooinside a named route&(bar)was never registered into the server'snamed_routes, so invokingbarat runtime failed when it reached the nestedinvoke foo. The adapter now records, per named route, which named routes it invokes, and when a server references a named route it attaches that route plus everything it transitively invokes (breadth-first, with already-attached routes skipped so cycles terminate). The existing "cannot invoke named route which was not defined" error is preserved for undefined targets at any depth.Files:
caddyconfig/httpcaddyfile/httptype.goAssistance Disclosure
This patch was developed with AI assistance. It was reviewed and tested before submission (affected package tests pass), and is submitted from a human-owned account that takes responsibility for the change.