Skip to content

added WorkflowServiceGrpc and IWorkflowServiceV4 #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v4.x.x
Choose a base branch
from
Open

added WorkflowServiceGrpc and IWorkflowServiceV4 #999

wants to merge 2 commits into from
+12,678 −0

Conversation

shijiesheng
Copy link
Member

What changed?

  • added client entities that maps 1:1 with thrift
  • added mappers to transform Proto to client entities. (mostly copied from thrift mappers)
  • added serviceclient.exceptions that map 1:1 with thrift. ServiceClientError is a catchall similar to TException.
  • added IWorkflowServiceV4 which is exactly same as IWorkflowService except for it's using the client entities.
  • added WorkflowServiceGrpc that implements the V4 interface

Plan

  • new V4 interface with new entities < This PR
  • replace all pointers to V4 in one go (Should be import change only)
  • remove all thrift related files

Why?

Thrift deprecation work

How did you test it?

Potential risks

Release notes

Documentation Changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@abhishekj720 abhishekj720 Awaiting requested review from abhishekj720 abhishekj720 is a code owner

@natemort natemort Awaiting requested review from natemort natemort is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shijiesheng