Enforce type safe check and fix code with type safe issues#18
Merged
timl3136 merged 4 commits intocadence-workflow:mainfrom Aug 28, 2025
Merged
Enforce type safe check and fix code with type safe issues#18timl3136 merged 4 commits intocadence-workflow:mainfrom
timl3136 merged 4 commits intocadence-workflow:mainfrom
Conversation
natemort
reviewed
Aug 28, 2025
|
|
||
| class ActivityWorker: | ||
| def __init__(self, client: Client, task_list: str, options: WorkerOptions): | ||
| def __init__(self, client: Client, task_list: str, options: WorkerOptions) -> None: |
Member
There was a problem hiding this comment.
I thought no value implied -> None, I'm sorry :(
Member
Author
There was a problem hiding this comment.
it does implied -> None, but MyPy does not like that.
natemort
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Enforce type safe check and fix code with type safe issue
Why?
CI check was added but not enforced
How did you test it?
CI test
Potential risks
Release notes
Documentation Changes