feat: Implement signal_with_start_workflow client method #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Li <[email protected]>
Signed-off-by: Tim Li <[email protected]>
shijiesheng
reviewed
Nov 3, 2025
|
|
||
| async def signal_with_start_workflow( | ||
| self, | ||
| workflow: Union[str, Callable], |
There was a problem hiding this comment.
maybe we require workflow to be WorkflowDefinition?
Suggested change
| workflow: Union[str, Callable], | |
| workflow: Union[str, WorkflowDefinition], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement signal_with_start_workflow client method
Why?
It's a necessary feature for signaling in python client
How did you test it?
Add an integration test to test signal_with_start.
Potential risks
Release notes
Documentation Changes