feat: implement heartbeat progress recovery through heartbeat details

[timl3136]

What changed?
implement heartbeat progress recovery through heartbeat details. While activity can fetch heartbeat details, it cannot yet do that during retry since retry handling is missing.

Why?
Allow the activity to pickup the progress that it heartbeated during retry

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Implements heartbeat progress recovery through heartbeat details, addressing the PydanticDataConverter.from_data limitation with empty type_hints. No issues remain.

✅ 1 resolved

✅ Bug: PydanticDataConverter.from_data doesn't support empty type_hints

📄 cadence/data_converter.py:42 📄 cadence/data_converter.py:54-55
The semantic change to DefaultDataConverter (empty type_hints now means "decode all values") is not mirrored in PydanticDataConverter. Its _decode_whitespace_delimited receives max_count=len(type_hints)=0, so the loop never executes and returns []. Then the for i, type_hint in enumerate(type_hints) loop also does nothing.

This means activity.heartbeat_details() (no type args) will silently return [] instead of the actual heartbeat values when PydanticDataConverter is in use. The two DataConverter implementations now have divergent behavior for the same input, violating the protocol contract.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}