Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
"cadence_idl_version": "ac43ecefe36469b88f4efd41e2a067fdcf7a8506"
},
"scripts": {
"dev": "next dev -p ${CADENCE_WEB_PORT:-8088} -H ${CADENCE_WEB_HOSTNAME:-0.0.0.0} | pino-pretty --messageKey message",
"dev": "CADENCE_WEB_PORT=${CADENCE_WEB_PORT:-8088} next dev -p ${CADENCE_WEB_PORT:-8088} -H ${CADENCE_WEB_HOSTNAME:-0.0.0.0} | pino-pretty --messageKey message",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary if we pass the env variable?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the only way nextJs would start the server on that port

"build": "NODE_ENV=production next build",
"build-standalone": "NODE_ENV=production NEXT_CONFIG_BUILD_OUTPUT=standalone next build",
"post-build-standalone": "tsx scripts/update-server-host.ts",
"start": "next start -p ${CADENCE_WEB_PORT:-8088} -H ${CADENCE_WEB_HOSTNAME:-0.0.0.0}",
"start": "CADENCE_WEB_PORT=${CADENCE_WEB_PORT:-8088} next start -p ${CADENCE_WEB_PORT:-8088} -H ${CADENCE_WEB_HOSTNAME:-0.0.0.0}",
"lint": "next lint",
"typecheck": "tsc --noemit",
"install-idl": "mkdir -p node_modules && cd node_modules && npx --yes github:Assem-Uber/tiged#release/v3.0.0-rc.01 https://github.com/cadence-workflow/cadence-idl#$npm_package_config_cadence_idl_version cadence-idl --force",
Expand Down
Loading