Skip to content

feat: [3/n] Add Columns Picker to Workflows List#1233

Open
adhityamamallan wants to merge 11 commits intocadence-workflow:masterfrom
adhityamamallan:pr3-columns-picker
Open

feat: [3/n] Add Columns Picker to Workflows List#1233
adhityamamallan wants to merge 11 commits intocadence-workflow:masterfrom
adhityamamallan:pr3-columns-picker

Conversation

@adhityamamallan
Copy link
Copy Markdown
Member

@adhityamamallan adhityamamallan commented Apr 7, 2026

Summary

Add and integrate new Columns Picker with Workflow List.

  • Add WorkflowsListColumnsPicker component with drag-and-drop reordering, search filtering, and toggle selection
  • Integrate columns picker into workflows header via columnsPickerProps (replaced showColumnsPicker boolean)
  • Add react-movable to esModules config for Jest (dependency of Baseweb's Drag and Drop List)

Test plan

Unit tests + ran locally.

Screen.Recording.2026-04-07.at.15.50.50.mov

@adhityamamallan adhityamamallan changed the title Pr3 columns picker feat: [3/n] Add Columns Picker to Workflows List Apr 7, 2026
@adhityamamallan adhityamamallan marked this pull request as ready for review April 7, 2026 13:56
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 8, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Adds a Columns Picker component to the Workflows List for flexible column customization. The DATETIME matcher issue that previously returned empty strings for missing values has been resolved.

✅ 1 resolved
Bug: DATETIME matcher returns empty string instead of null for missing values

📄 src/views/shared/workflows-list/config/workflows-list-columns.config.ts:100-110 📄 src/views/shared/workflows-list/helpers/get-workflows-list-column-from-search-attribute.ts:28-31 📄 src/views/shared/workflows-list/workflows-list.tsx:49-52
The generic DATETIME column matcher at line 108 returns String(value ?? '') when the value is missing, which produces an empty string ''. However, the "None" placeholder in workflows-list.tsx:49 only renders when content !== null. Other custom attribute types correctly return null for missing values (via the fallback in get-workflows-list-column-from-search-attribute.ts:30), so they show the "None" placeholder. This means missing datetime custom attributes will display as blank cells instead of showing "None", creating an inconsistent UX.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant