Skip to content

Fix styling for JSON copy buttons #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix styling for JSON copy buttons #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acf6072
Change styles
adhityamamallan Apr 15, 2025
f275e47
Remove dockerenv and dockerfile
adhityamamallan Apr 15, 2025
dcd388a
Fix styles
adhityamamallan Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...history/workflow-history-event-details-json/workflow-history-event-details-json.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { type ButtonOverrides } from 'baseui/button';

import type {
StyletronCSSObject,
StyletronCSSObjectOf,
Expand Down Expand Up @@ -25,3 +27,13 @@ const cssStylesObj = {

export const cssStyles: StyletronCSSObjectOf<typeof cssStylesObj> =
cssStylesObj;

export const overrides = {
copyButton: {
BaseButton: {
style: {
backgroundColor: 'rgba(0, 0, 0, 0)',
},
},
} satisfies ButtonOverrides,
};
10 changes: 8 additions & 2 deletions ...kflow-history/workflow-history-event-details-json/workflow-history-event-details-json.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ import PrettyJson from '@/components/pretty-json/pretty-json';
import useStyletronClasses from '@/hooks/use-styletron-classes';
import losslessJsonStringify from '@/utils/lossless-json-stringify';

import { cssStyles } from './workflow-history-event-details-json.styles';
import {
cssStyles,
overrides,
} from './workflow-history-event-details-json.styles';
import type { Props } from './workflow-history-event-details-json.types';

export default function WorkflowHistoryEventDetailsJson({ entryValue }: Props) {
Expand All @@ -19,7 +22,10 @@ export default function WorkflowHistoryEventDetailsJson({ entryValue }: Props) {
<div className={cls.jsonViewWrapper}>
<div className={cls.jsonViewContainer}>
<div className={cls.jsonViewHeader}>
<CopyTextButton textToCopy={textToCopy} />
<CopyTextButton
textToCopy={textToCopy}
overrides={overrides.copyButton}
/>
</div>
<PrettyJson json={entryValue} />
</div>
Expand Down
11 changes: 11 additions & 0 deletions ...iews/workflow-queries/workflow-queries-result-json/workflow-queries-result-json.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { styled as createStyled } from 'baseui';
import { type ButtonOverrides } from 'baseui/button';

export const styled = {
ViewContainer: createStyled<'div', { $isError: boolean }>(
Expand All @@ -24,3 +25,13 @@ export const styled = {
})
),
};

export const overrides = {
copyButton: {
BaseButton: {
style: {
backgroundColor: 'rgba(0, 0, 0, 0)',
},
},
} satisfies ButtonOverrides,
};
7 changes: 5 additions & 2 deletions src/views/workflow-queries/workflow-queries-result-json/workflow-queries-result-json.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import PrettyJson from '@/components/pretty-json/pretty-json';
import losslessJsonStringify from '@/utils/lossless-json-stringify';

import getQueryJsonContent from './helpers/get-query-json-content';
import { styled } from './workflow-queries-result-json.styles';
import { overrides, styled } from './workflow-queries-result-json.styles';
import { type Props } from './workflow-queries-result-json.types';

export default function WorkflowQueriesResultJson(props: Props) {
Expand All @@ -24,7 +24,10 @@ export default function WorkflowQueriesResultJson(props: Props) {
{content !== undefined && (
<>
<PrettyJson json={content} />
<CopyTextButton textToCopy={textToCopy} />
<CopyTextButton
textToCopy={textToCopy}
overrides={overrides.copyButton}
/>
</>
)}
</styled.ViewContainer>
Expand Down
12 changes: 12 additions & 0 deletions ...kflow-summary-tab/workflow-summary-tab-json-view/workflow-summary-tab-json-view.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { type ButtonOverrides } from 'baseui/button';

import type {
StyletronCSSObject,
StyletronCSSObjectOf,
Expand All @@ -19,3 +21,13 @@ const cssStylesObj = {

export const cssStyles: StyletronCSSObjectOf<typeof cssStylesObj> =
cssStylesObj;

export const overrides = {
copyButton: {
BaseButton: {
style: {
backgroundColor: 'rgba(0, 0, 0, 0)',
},
},
} satisfies ButtonOverrides,
};
7 changes: 5 additions & 2 deletions ...ws/workflow-summary-tab/workflow-summary-tab-json-view/workflow-summary-tab-json-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import useStyletronClasses from '@/hooks/use-styletron-classes';
import losslessJsonStringify from '@/utils/lossless-json-stringify';

import { jsonViewTabsOptions } from './workflow-summary-tab-json-view.constants';
import { cssStyles } from './workflow-summary-tab-json-view.styles';
import { cssStyles, overrides } from './workflow-summary-tab-json-view.styles';
import type { Props } from './workflow-summary-tab-json-view.types';

export default function WorkflowSummaryTabJsonView({
Expand Down Expand Up @@ -42,7 +42,10 @@ export default function WorkflowSummaryTabJsonView({
options={jsonViewTabsOptions}
onChange={({ activeKey }) => setActiveTab(activeKey.toString())}
/>
<CopyTextButton textToCopy={textToCopy} />
<CopyTextButton
textToCopy={textToCopy}
overrides={overrides.copyButton}
/>
</div>
{activeTab === 'result' && isWorkflowRunning ? (
<PrettyJsonSkeleton width="200px" />
Expand Down