Create improved DateFilterV2 component and update Basic Visibility filters #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhityamamallan
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the date filtering functionality by replacing the legacy DateFilter component with the improved DateFilterV2, updating types and defaults to support dynamic quick ranges and a better UX. Additionally, changes include updates to query parameter configurations, infinite query type definitions, and corresponding test adjustments.
- Replace the legacy DateFilter with DateFilterV2 in basic workflows filters
- Update query parameter types and defaults in domain-page configuration
- Revise infinite query types and adjust associated tests
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/domain-workflows-basic/config/domain-workflows-basic-filters.config.ts | Refactors date filter usage and types to use DateFilterV2 with new stringification helpers |
| src/views/domain-page/config/domain-page-query-params.config.ts | Updates date query parameter types and default values to use string-based relative values |
| src/views/domain-page/fixtures/domain-page-query-params.ts | Modifies fixture values to align with the new DateFilterValue type |
| src/hooks/use-merged-infinite-queries/* | Adjusts type definitions and generic parameters for infinite queries |
| src/components/date-filter-v2/* | Introduces new DateFilterV2 component, helper functions, constants, and test suites with updated UX and formatting logic |
| package.json | Adds TZ=UTC to test commands to ensure tests run in UTC |
adhityamamallan
force-pushed
the
date-filter-v2
branch
from
a13c6b1 to
d2adaf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Misc
Test plan
Added + updated unit tests, and ran locally.
Starting a new workflow off-screen and navigating back to the workflow list, to demonstrate fresh data being loaded:
Screen.Recording.2025-05-12.at.11.53.03.AM.mov