Skip to content

Use new IDL package for query consistency level changes #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Use new IDL package for query consistency level changes #6791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0e2a4f
feat(frontend): Use new IDL package for query consistency level changes
c-warren Apr 7, 2025
962bb73
Update thrift, update proto, update common mapper functions
c-warren Apr 7, 2025
523c9d6
make pr
c-warren Apr 7, 2025
2e63a88
Update CONTRIBUTING readme with IDL update instructions
c-warren Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 158 additions & 30 deletions .gen/go/shared/shared.go
View file
Open in desktop

Large diffs are not rendered by default.

309 changes: 155 additions & 154 deletions .gen/proto/history/v1/service.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

309 changes: 155 additions & 154 deletions .gen/proto/matching/v1/service.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 11 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,17 @@ If you make changes in the idls submodule and want to test them locally, you can

```replace github.com/uber/cadence-idl => ./idls```

### Using IDL Changes

Once your [Pull Request](#pull-requests) has been successfully merged you can update cadence to use the new version:

```bash
# Update the IDLs directory
git submodule foreach git pull origin master
# Update go to use the latest idl package
go get github.com/uber/cadence-idl@latest
```

## Pull Requests
After all the preparation you are about to write code and make a Pull Request for the issue.

Expand Down
2 changes: 1 addition & 1 deletion cmd/server/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ require (
github.com/startreedata/pinot-client-go v0.2.0 // latest release supports pinot v0.12.0 which is also internal version
github.com/stretchr/testify v1.9.0
github.com/uber-go/tally v3.3.15+incompatible // indirect
github.com/uber/cadence-idl v0.0.0-20241230191346-dcfe462b5c9c
github.com/uber/cadence-idl v0.0.0-20250407200939-f5ac3a987dca
github.com/uber/ringpop-go v0.8.5 // indirect
github.com/uber/tchannel-go v1.22.2 // indirect
github.com/valyala/fastjson v1.4.1 // indirect
Expand Down
4 changes: 2 additions & 2 deletions cmd/server/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,8 +412,8 @@ github.com/uber-go/tally v3.3.12+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyu
github.com/uber-go/tally v3.3.15+incompatible h1:9hLSgNBP28CjIaDmAuRTq9qV+UZY+9PcvAkXO4nNMwg=
github.com/uber-go/tally v3.3.15+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyufu1cEi0jdVnRdxvjnmU=
github.com/uber/cadence-idl v0.0.0-20211111101836-d6b70b60eb8c/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
github.com/uber/cadence-idl v0.0.0-20241230191346-dcfe462b5c9c h1:uda5vKt0Co2a3EyuLK90Z7zvavwo43HgsR9pHDZ7uag=
github.com/uber/cadence-idl v0.0.0-20241230191346-dcfe462b5c9c/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
github.com/uber/cadence-idl v0.0.0-20250407200939-f5ac3a987dca h1:0qJbFSpIjikuBH1xi0RdrmPlZY5T7+drcx0EvBSe7j0=
github.com/uber/cadence-idl v0.0.0-20250407200939-f5ac3a987dca/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
github.com/uber/jaeger-client-go v2.22.1+incompatible h1:NHcubEkVbahf9t3p75TOCR83gdUHXjRJvjoBh1yACsM=
github.com/uber/jaeger-client-go v2.22.1+incompatible/go.mod h1:WVhlPFC8FDjOFMMWRy2pZqQJSXxYSwNYOkTr/Z6d3Kk=
github.com/uber/jaeger-lib v2.2.0+incompatible h1:MxZXOiR2JuoANZ3J6DE/U0kSFv/eJ/GfSYVCjK7dyaw=
Expand Down
12 changes: 8 additions & 4 deletions common/types/mapper/proto/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,8 +1226,9 @@ func FromDescribeWorkflowExecutionRequest(t *types.DescribeWorkflowExecutionRequ
return nil
}
return &apiv1.DescribeWorkflowExecutionRequest{
Domain: t.Domain,
WorkflowExecution: FromWorkflowExecution(t.Execution),
Domain: t.Domain,
WorkflowExecution: FromWorkflowExecution(t.Execution),
QueryConsistencyLevel: FromQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand All @@ -1236,8 +1237,9 @@ func ToDescribeWorkflowExecutionRequest(t *apiv1.DescribeWorkflowExecutionReques
return nil
}
return &types.DescribeWorkflowExecutionRequest{
Domain: t.Domain,
Execution: ToWorkflowExecution(t.WorkflowExecution),
Domain: t.Domain,
Execution: ToWorkflowExecution(t.WorkflowExecution),
QueryConsistencyLevel: ToQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand Down Expand Up @@ -1503,6 +1505,7 @@ func FromGetWorkflowExecutionHistoryRequest(t *types.GetWorkflowExecutionHistory
WaitForNewEvent: t.WaitForNewEvent,
HistoryEventFilterType: FromEventFilterType(t.HistoryEventFilterType),
SkipArchival: t.SkipArchival,
QueryConsistencyLevel: FromQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand All @@ -1518,6 +1521,7 @@ func ToGetWorkflowExecutionHistoryRequest(t *apiv1.GetWorkflowExecutionHistoryRe
WaitForNewEvent: t.WaitForNewEvent,
HistoryEventFilterType: ToEventFilterType(t.HistoryEventFilterType),
SkipArchival: t.SkipArchival,
QueryConsistencyLevel: ToQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand Down
12 changes: 8 additions & 4 deletions common/types/mapper/thrift/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1781,8 +1781,9 @@ func FromDescribeWorkflowExecutionRequest(t *types.DescribeWorkflowExecutionRequ
return nil
}
return &shared.DescribeWorkflowExecutionRequest{
Domain: &t.Domain,
Execution: FromWorkflowExecution(t.Execution),
Domain: &t.Domain,
Execution: FromWorkflowExecution(t.Execution),
QueryConsistencyLevel: FromQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand All @@ -1792,8 +1793,9 @@ func ToDescribeWorkflowExecutionRequest(t *shared.DescribeWorkflowExecutionReque
return nil
}
return &types.DescribeWorkflowExecutionRequest{
Domain: t.GetDomain(),
Execution: ToWorkflowExecution(t.Execution),
Domain: t.GetDomain(),
Execution: ToWorkflowExecution(t.Execution),
QueryConsistencyLevel: ToQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand Down Expand Up @@ -2546,6 +2548,7 @@ func FromGetWorkflowExecutionHistoryRequest(t *types.GetWorkflowExecutionHistory
WaitForNewEvent: &t.WaitForNewEvent,
HistoryEventFilterType: FromHistoryEventFilterType(t.HistoryEventFilterType),
SkipArchival: &t.SkipArchival,
QueryConsistencyLevel: FromQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand All @@ -2562,6 +2565,7 @@ func ToGetWorkflowExecutionHistoryRequest(t *shared.GetWorkflowExecutionHistoryR
WaitForNewEvent: t.GetWaitForNewEvent(),
HistoryEventFilterType: ToHistoryEventFilterType(t.HistoryEventFilterType),
SkipArchival: t.GetSkipArchival(),
QueryConsistencyLevel: ToQueryConsistencyLevel(t.QueryConsistencyLevel),
}
}

Expand Down
6 changes: 4 additions & 2 deletions common/types/testdata/service_frontend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,9 @@ var (
FirstExecutionRunID: RunID,
}
DescribeWorkflowExecutionRequest = types.DescribeWorkflowExecutionRequest{
Domain: DomainName,
Execution: &WorkflowExecution,
Domain: DomainName,
Execution: &WorkflowExecution,
QueryConsistencyLevel: &QueryConsistencyLevel,
}
DescribeWorkflowExecutionResponse = types.DescribeWorkflowExecutionResponse{
ExecutionConfiguration: &WorkflowExecutionConfiguration,
Expand Down Expand Up @@ -447,6 +448,7 @@ var (
WaitForNewEvent: true,
HistoryEventFilterType: &HistoryEventFilterType,
SkipArchival: true,
QueryConsistencyLevel: &QueryConsistencyLevel,
}
GetWorkflowExecutionHistoryResponse = types.GetWorkflowExecutionHistoryResponse{
History: &History,
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ require (
github.com/startreedata/pinot-client-go v0.2.0 // latest release supports pinot v0.12.0 which is also internal version
github.com/stretchr/testify v1.9.0
github.com/uber-go/tally v3.3.15+incompatible
github.com/uber/cadence-idl v0.0.0-20241230191346-dcfe462b5c9c
github.com/uber/cadence-idl v0.0.0-20250407200939-f5ac3a987dca
github.com/uber/ringpop-go v0.8.5
github.com/uber/tchannel-go v1.22.2
github.com/urfave/cli/v2 v2.27.4
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,8 @@ github.com/uber-go/tally v3.3.12+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyu
github.com/uber-go/tally v3.3.15+incompatible h1:9hLSgNBP28CjIaDmAuRTq9qV+UZY+9PcvAkXO4nNMwg=
github.com/uber-go/tally v3.3.15+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyufu1cEi0jdVnRdxvjnmU=
github.com/uber/cadence-idl v0.0.0-20211111101836-d6b70b60eb8c/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
github.com/uber/cadence-idl v0.0.0-20241230191346-dcfe462b5c9c h1:uda5vKt0Co2a3EyuLK90Z7zvavwo43HgsR9pHDZ7uag=
github.com/uber/cadence-idl v0.0.0-20241230191346-dcfe462b5c9c/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
github.com/uber/cadence-idl v0.0.0-20250407200939-f5ac3a987dca h1:0qJbFSpIjikuBH1xi0RdrmPlZY5T7+drcx0EvBSe7j0=
github.com/uber/cadence-idl v0.0.0-20250407200939-f5ac3a987dca/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
github.com/uber/jaeger-client-go v2.22.1+incompatible h1:NHcubEkVbahf9t3p75TOCR83gdUHXjRJvjoBh1yACsM=
github.com/uber/jaeger-client-go v2.22.1+incompatible/go.mod h1:WVhlPFC8FDjOFMMWRy2pZqQJSXxYSwNYOkTr/Z6d3Kk=
github.com/uber/jaeger-lib v2.2.0+incompatible h1:MxZXOiR2JuoANZ3J6DE/U0kSFv/eJ/GfSYVCjK7dyaw=
Expand Down
5 changes: 4 additions & 1 deletion go.work.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ golang.org/x/crypto v0.9.0/go.mod h1:yrmDGqONDYtNj3tH8X9dzUun2m2lzPa9ngI6/RUPGR0
golang.org/x/crypto v0.10.0/go.mod h1:o4eNf7Ede1fv+hwOwZsTHl9EsPFO6q6ZvYR8vYfY45I=
golang.org/x/crypto v0.12.0/go.mod h1:NF0Gs7EO5K4qLn+Ylc+fih8BSTeIjAP05siRnAh98yw=
golang.org/x/crypto v0.14.0/go.mod h1:MVFd36DqK4CsrnJYDkBA3VC4m2GkXAM0PvzMCn4JQf4=
golang.org/x/crypto v0.24.0/go.mod h1:Z1PMYSOR5nyMcyAVAIQSKCDwalqy85Aqn1x3Ws4L5DM=
golang.org/x/image v0.0.0-20180708004352-c73c2afc3b81 h1:00VmoueYNlNz/aHIilyyQz/MHSqGoWJzpFv/HW8xpzI=
golang.org/x/image v0.0.0-20190802002840-cff245a6509b h1:+qEpEAPhDZ1o0x3tHzZTQDArnOixOzGD9HUJfcg0mb4=
golang.org/x/mobile v0.0.0-20200801112145-973feb4309de h1:OVJ6QQUBAesB8CZijKDSsXX7xYVtUhrkY0gwMfbi4p4=
Expand All @@ -662,12 +663,14 @@ golang.org/x/oauth2 v0.6.0/go.mod h1:ycmewcwgD4Rpr3eZJLSB4Kyyljb3qDh40vJ8STE5HKw
golang.org/x/oauth2 v0.8.0/go.mod h1:yr7u4HXZRm1R1kBWqr/xKNqewf0plRYoB7sla+BCIXE=
golang.org/x/sync v0.2.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.3.0/go.mod h1:FU7BRWz2tNW+3quACPkgCx/L+uEAv1htQ0V83Z9Rj+Y=
golang.org/x/sync v0.7.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.8.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.9.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.11.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.13.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.21.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/telemetry v0.0.0-20240521205824-bda55230c457 h1:zf5N6UOrA487eEFacMePxjXAJctxKmyjKUsjA11Uzuk=
golang.org/x/telemetry v0.0.0-20240521205824-bda55230c457/go.mod h1:pRgIJT+bRLFKnoM1ldnzKoxTIn14Yxz928LQRYYgIN0=
golang.org/x/term v0.15.0 h1:y/Oo/a/q3IXu26lQgl04j/gjuBDOBlx7X6Om1j2CPW4=
Expand All @@ -680,6 +683,7 @@ golang.org/x/text v0.8.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8=
golang.org/x/text v0.9.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8=
golang.org/x/text v0.12.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/text v0.13.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/text v0.16.0/go.mod h1:GhwF1Be+LQoKShO3cGOHzqOgRrGaYc9AvblQOmPVHnI=
golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU=
golang.org/x/tools v0.13.0/go.mod h1:HvlwmtVNQAhOuCjW7xxvovg8wbNq7LwfXh/k7wXUl58=
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d/go.mod h1:aiJjzUbINMkxbQROHiO6hDPo2LHcIPhhQsa9DLh0yGk=
Expand Down Expand Up @@ -725,7 +729,6 @@ gopkg.in/gcfg.v1 v1.2.3 h1:m8OOJ4ccYHnx2f4gQwpno8nAX5OGOh7RLaaz0pj3Ogs=
gopkg.in/resty.v1 v1.12.0 h1:CuXP0Pjfw9rOuY6EP+UvtNvt5DSqHpIxILZKT/quCZI=
gopkg.in/src-d/go-billy.v4 v4.3.0 h1:KtlZ4c1OWbIs4jCv5ZXrTqG8EQocr0g/d4DjNg70aek=
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ=
gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
lukechampine.com/adiantum v1.1.1 h1:4fp6gTxWCqpEbLy40ExiYDDED3oUNWx5cTqBCtPdZqA=
lukechampine.com/adiantum v1.1.1/go.mod h1:LrAYVnTYLnUtE/yMp5bQr0HstAf060YUF8nM0B6+rUw=
nhooyr.io/websocket v1.8.7 h1:usjR2uOr/zjjkVMy0lW+PPohFok7PCow5sDjLgX4P4g=
Expand Down
2 changes: 1 addition & 1 deletion idls
Open in desktop
Submodule idls updated from dcfe46 to f5ac3a