Refactor history queue factory #6907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| ) | ||
| for _, factory := range queueFactories { | ||
| historyEngImpl.queueProcessors[factory.Category()] = factory.CreateQueue( | ||
| shard, |
There was a problem hiding this comment.
shard.SetEngine() is called later in this function but the queue factory is calling shard.GetEngine(). Let's make sure the dependencies are clear and future proof.
There was a problem hiding this comment.
The queue processors are depending on shard context and history engine. History engine is depending on shard context.
There was a problem hiding this comment.
What is not clear is the dependency between history engine and shard context, but it's unrelated to this PR.
| @@ -204,14 +215,16 @@ func (e *historyEngineImpl) generateGracefulFailoverTasksForDomainUpdateCallback | |||
|
|
|||
| func (e *historyEngineImpl) lockTaskProcessingForDomainUpdate() { | |||
| e.logger.Debug("Locking processing for domain update") | |||
| e.txProcessor.LockTaskProcessing() | |||
| e.timerProcessor.LockTaskProcessing() | |||
| for _, processor := range e.queueProcessors { | |||
There was a problem hiding this comment.
not in the scope of this PR but let's see if we really need to lock task processing for these domain change callbacks.
taylanisikdemir
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor history queue factory
Why?
To unify some methods for creating history queues, which will make it a lot easier to introduce queuev2.
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes