feat(shard-distributor): add GetAssignedShardsCount method and limiting in shard creator canary #7534
+145
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arzonus
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
arzonus
force-pushed
the
limit-ephemeral-canary
branch
from
c8dd2fe to
0a5660f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
GetAssignedShardsCountmethod was added toExecutorShardCreatorwill stop creating shards if the number of assigned shards is greater than the maximum number of assigned shardsmanagedProcessorsCountcounter was added toExecutorWhy?
We observed some instability in the cluster caused by non-stop shard creation by canary. This PR limits canary to create no more than 1K shard per running instance.
managedProcessorsCountwas added to count number of created managed processor.sync.Mapdoesn't haveLen/Countmethods and only a range over the whole Map is a way to get the size of the map. To avoid N operations, the counter was added.How did you test it?