feat(history): cap decision task failure retries #7580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuprime
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
shuprime
force-pushed
the
feat/cap-decision-task-failure-retries
branch
3 times, most recently
from
a05ce5e to
4cd4f20
Compare
Shaddoll
reviewed
Jan 7, 2026
shuprime
changed the title
Shaddoll
reviewed
Jan 7, 2026
Shaddoll
reviewed
Jan 7, 2026
shuprime
force-pushed
the
feat/cap-decision-task-failure-retries
branch
from
a531a33 to
d35e786
Compare
… timeout handling Signed-off-by: shuprime <[email protected]>
Signed-off-by: shuprime <[email protected]>
…e <[email protected]> Signed-off-by: shuprime <[email protected]>
shuprime
force-pushed
the
feat/cap-decision-task-failure-retries
branch
from
d35e786 to
f078db7
Compare
Signed-off-by: shuprime <[email protected]>
natemort
reviewed
Jan 9, 2026
host/decision_timeout_test.go
Outdated
|
|
||
| poller.PollAndProcessDecisionTask(false, true) | ||
| s.Logger.Info("Waiting for decision task timeout (attempt 0)") | ||
| time.Sleep(2 * time.Second) |
Member
There was a problem hiding this comment.
These Sleep calls shouldn't be necessary, and if they are, it often indicates that the test is or will become flakey since timing can vary quite a bit.
We should be able to:
- Poll for a decision task, then don't respond (letting it time out).
- Poll for a second decision task, then don't respond (letting it time out)
- This will only have a task dispatched to it after the first one times out, so it's fine to start polling for the task before it actually happens.
- We can use GetWorkflowExecutionHistory to long poll for the workflow to complete.
- See here .
These are all very minor changes from what you have, overall this approach is great.
Signed-off-by: shuprime <[email protected]>
shuprime
force-pushed
the
feat/cap-decision-task-failure-retries
branch
from
3c2dddc to
5b45ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
timer_active_task_executor.goto checkDecisionAttemptagainstDecisionRetryMaxAttemptsWhy?
Related to the issue - Automatically Fail Workflows on Repeated Decision Task Failures #7294
How did you test it?
Release notes
Documentation Changes