fix(cadence-matching): stop tasklist when stopping the shardprocessor #7581
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Unload the tasklist and stop it when the shard processor is stopped
Why?
When the shard is assigned to another instance we need to make sure the tasklist is stopped, otherwise the tasklist keep processing the old task that are also requested from the new instance and this causes "Persistent store operation failure".
How did you test it?
Deployed the fix to a deployed environment, where cadence-matching is onboarded to the SD and checked that there are no more conflict in the updates of the task
Potential risks
Potential risk is that task lists can be stopped, and since the tasklists stopped are the one with higher load this can cause more errors "Failed to complete task" due to the list shutdown.
Release notes
Documentation Changes