fix: Replace tokenbucket with standard limiter on CLI #7585
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scanf-s
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Scanf-s
changed the title
Scanf-s
force-pushed
the
fix/remove-tokenbucket-in-cli
branch
from
1429544 to
b8d089e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replaced
common/tokenbucketwithcommon/clock/ratelimiterin the CLI'sAdminDeletefunction (tools/cli/admin_elastic_search_commands.go).Why?
This PR is the first step toward resolving the issue #7562.
The current custom
tokenbucketimplementation is only used in two placesAdminDeletefunction: Uses only basic rate limiting, seems straightforward to replace.common/persistence/wrappers/sampledmodule: Required priority support, whichcommon/clock/ratelimiterdoes not currently support.To replace the custom ratelimiter in the
AdminDeletefunction, I followed the comments on the ratelimiter.go 84 line and used theWaitfunction to ensure it waits until a token is available. This allows the implementation to leverage context-based cancellation.How did you test it?
Ran unit tests in
admin_elastic_search_commands_test.goPotential risks
Release notes
Documentation Changes