fix(scheduler): honor backfill overlap policy#8006
Open
officialasishkumar wants to merge 1 commit intocadence-workflow:masterfrom
Open
fix(scheduler): honor backfill overlap policy#8006officialasishkumar wants to merge 1 commit intocadence-workflow:masterfrom
officialasishkumar wants to merge 1 commit intocadence-workflow:masterfrom
Conversation
Backfill requests carry their own overlap policy, but the scheduler worker was building every backfill fire request with the schedule-level policy. This meant operators could request a one-off backfill with a different overlap behavior and still get the schedule default at execution time. Route backfilled fires through an overlap-policy-aware helper and preserve existing behavior for requests that leave the backfill policy unset by falling back to the schedule policy. Add a workflow regression test that verifies the backfill policy reaches the local fire activity. Release note (bug fix): Backfill schedule requests now honor their requested overlap policy when firing backfilled runs. Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
644132e to
313eea9
Compare
Code Review ✅ ApprovedUpdates the scheduler to correctly enforce the backfill overlap policy. No issues found. Rules ✅ All requirements metRepository Rules
1 rule not applicable. Show all rules by commenting Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Backfilled schedule fires now use the overlap policy from the queued backfill request when it is set. Unset backfill policies continue to fall back to the schedule-level policy. Closes #8005.
Why?
BackfillScheduleRequestandBackfillSignalpreserve a request-specificOverlapPolicy, butprocessBackfillspreviously calledprocessScheduleFire, which always built the fire activity request withinput.Policies.OverlapPolicy. As a result, a one-off backfill policy override was ignored at execution time.The fix routes backfilled fires through an overlap-policy-aware helper and keeps the default scheduled-fire path unchanged.
How did you test it?
go test ./service/worker/scheduler -run 'TestSchedulerWorkflowBackfillUsesBackfillOverlapPolicy|TestBackfillOverlapPolicy|TestProcessBackfillsRespectsPause|TestBackfillFireComputation'\n\ngo test ./service/worker/scheduler\n\nmake pr GEN_DIR=service/worker/scheduler\n\nPotential risks\n\nLow. This only changes backfill execution when the backfill request supplies an explicit overlap policy. Backfills without an explicit policy retain the prior schedule-policy behavior.\n\nRelease notes\n\nBackfill schedule requests now honor their requested overlap policy when firing backfilled runs. #8005\n\nDocumentation Changes\n\nN/A\n