Skip to content

Add multi-substrate Michaelis–Menten kinetics #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

AntoniaBerger
Copy link
Collaborator

This PR adds milti-substrate Michaelis Menten and resolves #385.
The Residuum and Jacobi implementations have been adapted accordingly.
A test has been added to compare the implement and AD derivation. Documentation has been updated.

This commit adds milti-substrate Michaelis Menten.
The Residuum and Jacobi implementations have been adapted accordingly.
A test has been added to compare the implement and AD derivation.
Documentation has been updated.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • doc/modelling/reaction/michaelis_menten_kinetics.rst: Language not supported

@AntoniaBerger AntoniaBerger changed the title Add multi-substrate Michaelis Menten Add multi-substrate Michaelis–Menten kinetics Apr 4, 2025
@AntoniaBerger AntoniaBerger requested a review from jbreue16 April 4, 2025 10:56
Copy link
Contributor

@jbreue16 jbreue16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there going to be a reference data test?

@AntoniaBerger AntoniaBerger force-pushed the feature/multi_substrat_michaelis_menten branch from bd9fe82 to 32626f2 Compare April 4, 2025 11:59
@AntoniaBerger AntoniaBerger force-pushed the feature/multi_substrat_michaelis_menten branch from 32626f2 to 090107a Compare April 4, 2025 12:36
@AntoniaBerger
Copy link
Collaborator Author

The PR #397 will also add support multi substrate Michaelis-Menten kinetics.
So this PR is closed since another PR will add the feature.

@github-project-automation github-project-automation bot moved this from Todo to Done in CADET-Project May 16, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
@jbreue16 jbreue16 deleted the feature/multi_substrat_michaelis_menten branch May 16, 2025 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add multi-substrate kinetics
2 participants