Skip to content

Overload ScalarParameter methods for reaction model compatibility #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

cbix
Copy link
Member

@cbix cbix commented May 16, 2025

When using ScalarParameter in a reaction model, the code generated from the configuration wouldn't compile because it generates code with invalid function headers, e.g.

inline void reserve(unsigned int nReactions, unsigned int nComp, unsigned int nBoundStates)
{
  _Kh20.reserve(nReactions, nComp, nBoundStates);
  // [...]
}

This PR fixes the situation by overloading the existing headers with ones compatible with code generated from the reaction model codegen template. It is required for #413.

Copy link

github-actions bot commented May 16, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cbix

This comment was marked as resolved.

@cbix

This comment was marked as resolved.

@cbix cbix requested a review from jbreue16 May 19, 2025 13:59
@cbix cbix moved this from Todo to Awaiting Review in CADET Repositories May 19, 2025
Copy link
Contributor

@jbreue16 jbreue16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution! Can be merged imo, after two small documentation changes

@github-project-automation github-project-automation bot moved this from Awaiting Review to In Progress in CADET Repositories May 19, 2025
@jbreue16 jbreue16 merged commit 63d5652 into master May 19, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in CADET Repositories May 19, 2025
@jbreue16 jbreue16 deleted the fix/scalar-param-headers branch May 19, 2025 14:41
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants