Add ACT isotherm #415
Open
Add ACT isotherm #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should rebase onto master before making further changes, since binding tests have been added to the CI |
WFlynnZ
force-pushed
the
feature/add_ACT_isotherm
branch
from
3ae52e4 to
9e85815
Compare
|
Ive changed the file encoding to utf-8, which is our standard encoding and which was also the reason why it didnt build for the mac CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the ACT isotherm, a modified Langmuir isotherm with pH (or salt) dependence on the Qmax and Keq parameter.