-
Notifications
You must be signed in to change notification settings - Fork 38
Fix include build dir #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
02cfc52 to
02f94ba
Compare
|
Doesnt seem like its fixed, or am I missing something? |
ef12b85 to
e6c2944
Compare
Looked a bit within the coverage report by printing the coverage report additionally directly to stdout as auch can see here within the |
4ea262e to
d95967f
Compare
Add fix to codecov.yaml Fix ignore flag within codecov.yaml
d95967f to
46e3886
Compare
jbreue16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I'd say we cannot get a meaningful by line coverage for the binding files since they simply dont exist as such under src (only without the templated code). So lets put an end to this here.
Ill merge this PR since this still fixes #484
One of the current issues were the build files not covered by codecov #482. With this PR, these reports should be covered by using the fixes option within the
.codecov.yamloption. This should map allbuild/srcreports tosrc. Still not sure wether it actually works as intended tbh. As a sideeffect, i also fixed the PR #484. It was part of.codecov.yamlnot beeing properly configured. Codecov report can be found here.Changed the
Generate Coverage Reportstep so it spams the whole coverage report to stdout. Used it for bugfixing. I would leave it like this but if someone has a different opinion about to much "meaningless" output it is not a big deal to change it back.