Skip to content

Conversation

@daklauss
Copy link
Member

@daklauss daklauss commented Sep 5, 2025

One of the current issues were the build files not covered by codecov #482. With this PR, these reports should be covered by using the fixes option within the .codecov.yaml option. This should map all build/src reports to src. Still not sure wether it actually works as intended tbh. As a sideeffect, i also fixed the PR #484. It was part of .codecov.yaml not beeing properly configured. Codecov report can be found here.

Changed the Generate Coverage Report step so it spams the whole coverage report to stdout. Used it for bugfixing. I would leave it like this but if someone has a different opinion about to much "meaningless" output it is not a big deal to change it back.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 79 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daklauss daklauss force-pushed the fix-coverage-report branch from 02cfc52 to 02f94ba Compare September 5, 2025 12:55
@jbreue16
Copy link
Contributor

Doesnt seem like its fixed, or am I missing something?
https://app.codecov.io/gh/cadet/cadet-core/tree/fix-coverage-report

@daklauss daklauss force-pushed the fix-coverage-report branch 4 times, most recently from ef12b85 to e6c2944 Compare September 30, 2025 09:31
@daklauss
Copy link
Member Author

Doesnt seem like its fixed, or am I missing something? https://app.codecov.io/gh/cadet/cadet-core/tree/fix-coverage-report

Looked a bit within the coverage report by printing the coverage report additionally directly to stdout as auch can see here within the Generate Coverage Report step. gcovr does generate a report for the build files and it always has, but because it is not able to compare the files with the CADET-Core repository the codecovaction does not upload it to codecov as you can see within the Upload Coverage to Codecov step. It just throws warnings:

warning - 2025-09-30 09:46:58,363 -- xcrun is not installed or can't be found.
warning - 2025-09-30 09:46:58,396 -- Running gcov on the following list of files:
warning - 2025-09-30 09:46:58,396 -- /home/runner/work/CADET-Core/CADET-Core/build/ThirdParty/sundials/src/nvec_ser/CMakeFiles/sundials_nvecserial_static.dir/nvector_serial.c.gcno
.
.
.
warning - 2025-09-30 09:46:58,446 -- /home/runner/work/CADET-Core/CADET-Core/build/src/build-tools/templateCodeGen.ltrans8.ltrans.gcno
warning - 2025-09-30 09:46:58,446 -- /home/runner/work/CADET-Core/CADET-Core/build/src/build-tools/CMakeFiles/templateCodeGen.dir/templateCodeGen.cpp.gcno
warning - 2025-09-30 09:47:02,239 -- coverage.py is not installed or can't be found.

@daklauss daklauss force-pushed the fix-coverage-report branch 8 times, most recently from 4ea262e to d95967f Compare October 2, 2025 12:45
Add fix to codecov.yaml

Fix ignore flag within codecov.yaml
@daklauss daklauss force-pushed the fix-coverage-report branch from d95967f to 46e3886 Compare October 2, 2025 13:05
@daklauss daklauss self-assigned this Oct 2, 2025
@daklauss daklauss requested a review from jbreue16 October 2, 2025 13:52
@jbreue16 jbreue16 marked this pull request as ready for review October 10, 2025 16:38
Copy link
Contributor

@jbreue16 jbreue16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I'd say we cannot get a meaningful by line coverage for the binding files since they simply dont exist as such under src (only without the templated code). So lets put an end to this here.
Ill merge this PR since this still fixes #484

@github-project-automation github-project-automation bot moved this from Todo to In Progress in CADET Repositories Oct 10, 2025
@jbreue16 jbreue16 merged commit 09652ec into master Oct 10, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in CADET Repositories Oct 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants