Fix MCT sensitivities for CHANNEL_CROSS_SECTION_AREAS
#549
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linear and Langmuir exchange are changed
jbreue16
reviewed
Jan 16, 2026
Contributor
jbreue16
left a comment
jbreue16
left a comment
There was a problem hiding this comment.
Looks good, maybe @hannahlanzrath can test this, didn't you have a test case?
Collaborator
Author
|
I have run the file @hannahlanzrath send me. |
Collaborator
|
I can test this in an optimization next week if that helps :) |
jbreue16
approved these changes
Jan 16, 2026
Contributor
jbreue16
left a comment
jbreue16
left a comment
There was a problem hiding this comment.
I have run the file @hannahlanzrath send me. The sensitivies are close to zero (not equal) for the
channel_cross_section_arearof the first channel. Which makes sense in my mind.
Ok I think thats good enough
I can test this in an optimization next week if that helps :)
That'd still be appreciated
jbreue16
changed the title
CHANNEL_CROSS_SECTION_AREAS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the parameter handling for channel cross sections and adds parameter registration in both the
LangumirExchangeBaseandLinearExchangeBaseclasses.The changes ensure that channel cross sections are treated as differentiable parameters (
active) and enables sensitivities for this parameter.The sensitivity path
model.root.input.sensitivity.param_001.sens_partypeaccounts for the channel dependencies.Fixes #536