Open
Conversation
|
Thank you for your submission, we really appreciate it! Like many open-source projects we ask that you sign our Contributor License Agreement before we can accept your contribution.
- [ ] The CADET maintainers know my real name.
At least one of the following two applies:
- [ ] The CADET maintainers know my current employer.
- [ ] I am *not* making this contribution on behalf of my current employer.
|
ad52dcc to
da1efad
Compare
da1efad to
70ec560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding CADET-Verification branch with python scripts: cadet/CADET-Verification#97
This PR introduces a new binding model type ("SPLINE" and "EXT_SPLINE") that replaces analytical adsorption isotherms with a monotonic cubic spline interpolation of user-provided equilibrium data.
Instead of evaluating a predefined isotherm (e.g., Langmuir), the model computes the equilibrium solid-phase concentration q* from tabulated (C_VALS, Q_VALS) data using cubic spline interpolation. The resulting equilibrium relation is embedded into the standard kinetic formulation:
Key features:
model_weights/spline_input_parameters/{C_VALS, Q_VALS}
This enables: