Fix ruff #39
Fix ruff #39
Conversation
daklauss
force-pushed
the
fix-ruff
branch
3 times, most recently
from
47eb88e to
c43ad89
Compare
|
The great formatting has been done. Added preview rules to the linter/formater. Ignored Rules that caused warnings. added pre-commit-config.yaml. Also let ruff automaticaly by pre commit hook check and format linting stuff. |
| ], | ||
| [ | ||
| 0, 1, 0, 1, 4, 5, 6, 7, 8, 9, 10, |
There was a problem hiding this comment.
Not sure how to adress this one ....... :/
| 'parameters_start': { | ||
| 'inlet': { | ||
| 'c': np.array([0., 1.]), | ||
| "parameters_start": { |
There was a problem hiding this comment.
Do you prefer single or double quotes?
There was a problem hiding this comment.
I feel that double quotes are more standard these days...
tests/test_system.py
Outdated
| 0, 1, 0, 1, 4, 5, 6, 7, 8, 9, 10, | ||
| 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, | ||
| 22, 23, 24, 25, 26, 22, 23 | ||
| 0, |
There was a problem hiding this comment.
Like one line for every number ? ... mkay
There was a problem hiding this comment.
Add trailing comma to avoid line break. (See https://docs.astral.sh/ruff/settings/#format_skip-magic-trailing-comma)
There was a problem hiding this comment.
This wont work for this case, because the entire line is to long. Trailing comma does not prevent line break if line is to long i guess....
| state: str | ||
| ) -> np.ndarray: | ||
| self, origin_list: list[(dict, float)], state: str | ||
| ) -> np.ndarray: |
There was a problem hiding this comment.
Add trailing comma to avoid line break. (See https://docs.astral.sh/ruff/settings/#format_skip-magic-trailing-comma).
| def get_coupled_state(self, | ||
| origin_list: list[(dict, float)], | ||
| state: str | ||
| ) -> np.ndarray: |
There was a problem hiding this comment.
Add trailing comma to avoid line break. (See https://docs.astral.sh/ruff/settings/#format_skip-magic-trailing-comma)
|
I removed the automated formatter in the pre commit file. If someone wants to use the autoformater he should handle it by himself with care. Otherwise i specified the directories to check (CadetPythonSim and tests). There a possibilities to ignore rules for specific files by setting: This will be most likely necessary in Cadet Process. |
daklauss
force-pushed
the
fix-ruff
branch
3 times, most recently
from
d836d57 to
37247c5
Compare
|
Reworked the optional dependencies and using dependency groups for development related dependencies. |
.github/workflows/ruff.yml
Outdated
| @@ -1,17 +1,10 @@ | |||
| name: Ruff | |||
| on: [ push, pull_request ] | |||
| on: [ push ] | |||
There was a problem hiding this comment.
Please remind me, was there a reason not to include this for PRs?
There was a problem hiding this comment.
Not a strict reason. I guess i wanted to try to avoid duplicated execution of jobs. Otherwise it would execute this job twice if pushing on a pull_request.
Pull request to fix the linter problem as described in #36 . Added the preview rules that may be unstable but now, ruff linter checks also for things like linespace etc. Also trying to update Ruff pipeline.
Closes #36