Fix parallelization by fixing pickling and un-pickling of CADET-dll #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronald-jaepel
force-pushed
the
fix/pickle_capi
branch
from
a13b294 to
0c31aad
Compare
ronald-jaepel
force-pushed
the
fix/pickle_capi
branch
3 times, most recently
from
8cf9717 to
516635e
Compare
schmoelder
requested changes
Nov 19, 2024
Contributor
schmoelder
left a comment
schmoelder
left a comment
There was a problem hiding this comment.
Thanks for fixing this and for adding tests!
Contributor
|
Just out of curiosity, can you elaborate what function |
…on tests Fixed pickle support by removing all ctypes pointers from the state in CadetDLLRunner.__getstate__ and recreating the dll interface in CadetDLLRunner.__setstate__ . Fixed "no attribute __frozen" error by casting Cadet state into addict.Dict on Cadet.__setstate__ .
Contributor
Author
|
ronald-jaepel
force-pushed
the
fix/pickle_capi
branch
from
516635e to
17cb5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #25 with CADET-Python v1.0.0 the parallelization is broken because we can not pickle ctype pointers.
My proposed solution is to remove all pointers from the state, only save the
_cadet_pathand then on__getstate__re-load the dll and pointers in the child-thread.ToDo: