-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EOC tests for aggregation and fragmentation in crystallization #44
base: main
Are you sure you want to change the base?
Conversation
Thanks Flynn ! |
Hi Jan, we actually have aggregation+breakage+DPFR in our paper, but I did not include it here because I thought we have 1. aggregation and breakage, separately, 2. aggregation and breakage combined, 3. aggregation+DPFR and breakage+DPFR, separately, if these tests all pass, especially we have 2 and 3 passed, what could go wrong if we do aggregation+breakage+DPFR, seems somewhat redundant to me. But I can certainly add if you think it is necessary. |
Hm I see.. I think it would be best to have tests for all combinations listed in your comment on the core side. Theres always things that can go wrong with implementation unexpectedly |
mpmath is used to compute reference solutions with enhanced precision for the crystallization fragmentation module.
fbf9ec4
to
06e0e40
Compare
Okay sounds good, I just added another case covering aggregation+fragmentation in a DPFR tests. |
…com/cadet/CADET-Verification into add_aggregation_fragmentation_tests
This PR implements EOC tests for aggregation and fragmentation equations.