Skip to content

fix: debounce now playing toast to show correct track metadata #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
endafk wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: debounce now playing toast to show correct track metadata #1338

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d85bf9
fix: debounce now playing toast to show correct track metadata
endafk Mar 26, 2026
651e9a3
fix: correct import order and add section separator for linter
endafk Mar 26, 2026
9637160
Update services/Players.qml
endafk Mar 26, 2026
663ce95
fix: capture player at signal time to guard against active player switch
endafk Mar 26, 2026
2c515b9
Merge branch 'main' into fix/now-playing-notification-race-condition
endafk Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions services/Players.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
pragma Singleton

import QtQuick
import QtQml
import Quickshell
import Quickshell.Io
Expand All @@ -22,15 +23,34 @@ Singleton {

Connections {
function onPostTrackChanged() {
nowPlayingTimer.pendingPlayer = root.active;
nowPlayingTimer.restart();
}

target: root.active
}

// Debounce the now playing toast to avoid showing stale metadata.
// Some players (e.g. Spotify) emit postTrackChanged as soon as the track
// ID changes, before the title/artist properties are updated in a follow-up
// D-Bus signal. Waiting a short time ensures the metadata has settled.
// The player is captured at signal time so that an active player switch
// during the debounce window does not show metadata from the wrong player.
Timer {
id: nowPlayingTimer

property MprisPlayer pendingPlayer: null

interval: 300
onTriggered: {
if (!Config.utilities.toasts.nowPlaying) {
return;
}
if (root.active.trackArtist != "" && root.active.trackTitle != "") {
Toaster.toast(qsTr("Now Playing"), qsTr("%1 - %2").arg(root.active.trackArtist).arg(root.active.trackTitle), "music_note");
if (pendingPlayer && pendingPlayer === root.active && pendingPlayer.trackArtist != "" && pendingPlayer.trackTitle != "") {
Toaster.toast(qsTr("Now Playing"), qsTr("%1 - %2").arg(pendingPlayer.trackArtist).arg(pendingPlayer.trackTitle), "music_note");
}
pendingPlayer = null;
}

target: root.active
}

PersistentProperties {
Expand Down