fix: replace suspend-then-hibernate with hybrid-sleep#1380
Open
kellyson71 wants to merge 2 commits into
Open
Conversation
suspend-then-hibernate requires a pre-configured hibernate setup (swap partition/file with resume= kernel param) and its systemd unit may not be present on all distributions. hybrid-sleep achieves the same goal (saving state to disk while suspending to RAM) and is more universally supported. Also exposes sleep icon/command in SessionConfig so users can override the default via their config file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hybrid-sleep requires disk-based hibernation. Systems with only zram have no swap on disk, so hybrid-sleep fails silently. Plain suspend is the correct default for these systems. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Well, im having problems with suspend-then-hibernate, so i come to search if anyone have submitted a PR related. Im gladly that you submitted that, but your description and your code diverges. While you are saying that you will change to hybrid-sleep, actually you changed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Sleeplauncher action and the idle timeout action both usesystemctl suspend-then-hibernate, which:resume=kernel param)suspend-then-hibernate.servicemay simply not exist)Solution
Replace with
systemctl hybrid-sleep, which:Additionally,
sleepis now exposed as a named entry inSessionConfig(alongsidelogout,shutdown,hibernate,reboot), so users can override it in their config file.Changes
config/LauncherConfig.qml— Sleep action:suspend-then-hibernate→hybrid-sleep, updated descriptionconfig/GeneralConfig.qml— idle timeout action:suspend-then-hibernate→hybrid-sleepconfig/SessionConfig.qml— addedsleepicon (bedtime) and command (hybrid-sleep)config/Config.qml— exposesleepicon/command inserializeSession()🤖 Generated with Claude Code