Add Pomodoro timer to dashboard#1457
Open
Mentigen wants to merge 6 commits into
Open
Conversation
Adds a self-contained Pomodoro timer to the dashboard: - PomodoroService singleton (services/PomodoroService.qml) manages timer state: 3-work/1-long-break cycle (6 phases), idle mode after breaks, animated ring progress, sound via mpv - Pomodoro widget (modules/dashboard/Pomodoro.qml) shows a circular progress ring with drag-to-seek, phase dot strip, play/pause/prev/next controls, and a settings section (work/break/long-break durations, sound enable + volume) - Content.qml: add Pomodoro tab between Media and Performance
SpinBox inputs in the Pomodoro settings panel were not receiving keyboard input because needsKeyboard only tracked the Media tab. Now Pomodoro exposes needsKeyboard tied to its CollapsibleSection, and Content.qml propagates it up the chain so WlrLayershell requests keyboard focus.
Mentigen
changed the title
- Add pragma ComponentBehavior: Bound - Qualify all svc accesses as root.svc in child elements - Expand inline arrow functions to multi-line format with semicolons - Expand inline Behavior block
Mentigen
changed the title
|
this fits more likely to be a plugin imo #1384 |
Author
|
Thanks for the pointer to #1384! I agree that a plugin system would be the ideal home for niche features like this. However, #1384 is still a feature request with no implementation yet - the dashboard tabs injection point listed there doesn't exist in code. There's no plugin mechanism to use right now. In the meantime, this PR follows the exact same pattern as existing dashboard tabs, so the integration is minimal and self-contained. If the plugin system lands in the future, the Pomodoro module could be extracted into a standalone plugin without touching core. Happy to hear the maintainers' view on whether to hold off or proceed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Pomodoro timer as a new tab in the dashboard.
Test plan