feat: add sidebar showOnHover support and drawers isOpen IPC#1505
Open
silentone12725 wants to merge 4 commits into
Open
feat: add sidebar showOnHover support and drawers isOpen IPC#1505silentone12725 wants to merge 4 commits into
silentone12725 wants to merge 4 commits into
Conversation
Author
|
Note: the `check-qml` CI failure is a pre-existing issue on `main` (see runs 26436750421 and 26350256810) unrelated to this PR. The `check-cpp` and `lint` checks both pass. |
- Add showOnHover property to SidebarConfig (defaults to false) - Show sidebar on hover when cursor enters top-right corner - Hide sidebar when cursor leaves sidebar area or exits screen - Add sidebarShortcutActive flag to preserve shortcut-triggered state - Add isOpen(drawer) to drawers IPC target for external state queries Closes caelestia-dots#226
fb76932 to
8ec2b3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds hover-to-open support for the sidebar, consistent with how `launcher` and `dashboard` already work. Also adds an `isOpen` function to the `drawers` IPC target for external state queries.
Changes
Behaviour
When `sidebar.showOnHover` is enabled in `shell.json`, moving the cursor to the top-right corner opens the sidebar instantly. The sidebar stays open while the cursor is within the sidebar or session panel area, and closes automatically when the cursor leaves. Drag gestures and keyboard shortcuts continue to work as before.
Related
Closes #226