Skip to content

fix: launcher interrupt ordering race with Hyprland catchall #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hdcy wants to merge 1 commit into from
Closed

fix: launcher interrupt ordering race with Hyprland catchall #1543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions modules/Shortcuts.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import qs.modules.nexus
Scope {
id: root

property bool launcherInterrupted
property int launcherInterruptCount
readonly property bool hasFullscreen: Hypr.focusedWorkspace?.toplevels.values.some(t => t.lastIpcObject.fullscreen > 1) ?? false

// qmllint disable unresolved-type
Expand Down Expand Up @@ -64,13 +64,15 @@ Scope {
// qmllint enable unresolved-type
name: "launcher"
description: "Toggle launcher"
onPressed: root.launcherInterrupted = false
onPressed: root.launcherInterruptCount = 0
onReleased: {
if (!root.launcherInterrupted && !root.hasFullscreen) {
// Only toggle if no more than one interrupt fired (Super_L itself via catchall).
// Two or more interrupts means another key was pressed while holding Super.
if (root.launcherInterruptCount <= 1 && !root.hasFullscreen) {
const visibilities = Visibilities.getForActive();
visibilities.launcher = !visibilities.launcher;
}
root.launcherInterrupted = false;
root.launcherInterruptCount = 0;
}
}

Expand All @@ -79,7 +81,7 @@ Scope {
// qmllint enable unresolved-type
name: "launcherInterrupt"
description: "Interrupt launcher keybind"
onPressed: root.launcherInterrupted = true
onPressed: root.launcherInterruptCount++
}

// qmllint disable unresolved-type
Expand Down