Skip to content

fix(internal): add usingLua to HyprExtras for idle action gating#1553

Merged
soramanew merged 14 commits into
caelestia-dots:mainfrom
Mestane:chore-lua-lua
Jun 14, 2026
Merged

fix(internal): add usingLua to HyprExtras for idle action gating#1553
soramanew merged 14 commits into
caelestia-dots:mainfrom
Mestane:chore-lua-lua

Conversation

@Mestane

@Mestane Mestane commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Completes the Lua migration started in #1478.

  • Exposes usingLua on the Hypr singleton (bound to Hyprland.usingLua) and passes it into HyprExtras via QML binding, avoiding duplication of Quickshell's config detection logic in C++
  • Gates idle/return actions in IdleMonitors.qml based on config type
  • Gates applyOptions in HyprExtras to use eval hl.config instead of keyword when on Lua
  • Reverts hardcoded Lua defaults in generalconfig.hpp in favor of runtime detection
  • Fixes undefined workspace dispatch in Workspaces.qml

Closes #1478

@soramanew soramanew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good, just needs a few tweaks.

Comment thread plugin/src/Caelestia/Internal/hyprextras.hpp Outdated
Comment thread modules/windowinfo/Buttons.qml Outdated
@Mestane

Mestane commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

OMG ! I hate sed command. I'll never use it again.

@Mestane Mestane requested a review from soramanew June 11, 2026 18:28
@Mestane

Mestane commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

replaced C++ systeminfo detection with QML binding usingLua is now passed in from QML via HyprExtras { usingLua: Hyprland.usingLua } and exposed through the Hypr singleton as Hypr.usingLua, removing the need to duplicate Quickshell's config detection logic in C++.

@soramanew soramanew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@soramanew soramanew merged commit 7f35823 into caelestia-dots:main Jun 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants