fix(internal): add usingLua to HyprExtras for idle action gating#1553
Merged
Conversation
soramanew
requested changes
Jun 11, 2026
soramanew
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks pretty good, just needs a few tweaks.
Contributor
Author
|
OMG ! I hate sed command. I'll never use it again. |
Contributor
Author
|
replaced C++ systeminfo detection with QML binding usingLua is now passed in from QML via |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the Lua migration started in #1478.
usingLuaon theHyprsingleton (bound toHyprland.usingLua) and passes it intoHyprExtrasvia QML binding, avoiding duplication of Quickshell's config detection logic in C++IdleMonitors.qmlbased on config typeapplyOptionsinHyprExtrasto useeval hl.configinstead ofkeywordwhen on Luageneralconfig.hppin favor of runtime detectionWorkspaces.qmlCloses #1478